Add tz attribute to handlebar date function #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
requested changes
Dec 29, 2022
src/meta.ts
Outdated
| @@ -130,7 +130,7 @@ export class Meta { | |||
| const vraw = this.setValue( | |||
| handlebars.compile(tag.attrs['pattern'])({ | |||
| date: function (format) { | |||
| return moment(currentDate).utc().format(format); | |||
| return moment(currentDate).tz(tag.attrs['timezone']).format(format); | |||
There was a problem hiding this comment.
Instead of an extra attribute it would be better to add an hash arg to the handlebar func like: https://handlebarsjs.com/guide/expressions.html#helpers-with-hash-arguments
date: function (format, options) {
const m = moment(currentDate);
Object.keys(options.hash).forEach(key => {
switch (key) {
case "tz":
m.tz(options.hash[key]);
break;
default:
throw new Error(`Unknown ${key} attribute`);
}
})
return m.format(format);
}# no tz
type=schedule,pattern={{date 'YYYYMMDD-hhmmss'}}
# with tz
type=schedule,pattern={{date 'YYYYMMDD-hhmmss' tz='Asia/Tokyo'}}
There was a problem hiding this comment.
@crazy-max Thanks for your review. I have updated.
crazy-max
requested changes
Jan 5, 2023
There was a problem hiding this comment.
Can you also update the example in global expression section of the README: https://github.com/docker/metadata-action#date-format ?
Done it ! |
crazy-max
reviewed
Jan 6, 2023
Signed-off-by: chroju <chroju@users.noreply.github.com>
|
squashed and forced to push 👍 |
crazy-max
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250 . Add
timezoneparameters totype=scheduleandtype=raw.